Changeset ce40b83 in Lumiera

Timestamp:

2026-06-01T21:55:10Z (3 months ago)

Author:

Ichthyostega <prg@…>

Branches:

dev/play, documentation, integration

Children:

f3dcbfe

Parents:

b804015c

git-author:

Ichthyostega <prg@…> (01/06/26 21:33:25)

git-committer:

Ichthyostega <prg@…> (01/06/26 21:55:10)

Message:

Establish DataSink identity and fix remaining tests

The test suite is now green again.

The design rework and clean-up of unnecessary test-driven functionality
in the DiagnosticBufferProvider and DiagnosticOutputSlot required
to break some very old test-setup, using fake instances of the relevant
context facilities. This setup however was used by the newer family
of test support facilities, notable the MockJob, MockSegmentation
and MockDispatcher. These required a set of DataSink handles to be
present (even while they are not used currently).

This could be fixed easily now, relying on the simplified internal structure
of the OutputSlot: by re-arranging the types, the implied identity of the
DataSink handles could be made explicit, allowing for equality comparison.

Remark: even while DataSink with only a single abstracted function,
using function notation turned out to be rather confusing at usage site.
Naming this function as lockFrame(frameNo) clarifies its purpose nicely.
That call is effectively abstracted by means of the buffer type,
relying on the VTable in the BufferProvider implementation.

(No files)