Ticket #49 (closed todo: worksforme)

Opened 3 years ago

Last modified 9 months ago

gavl pkg-config problems

Reported by: ct Owned by:
Priority: normal Milestone: 0integration
Component: lumiera Keywords:
Cc: Blocked By:
Blocking:

Description

gisles spotted following error:

gcc -DPACKAGE_NAME=\"lumiera\" -DPACKAGE_TARNAME=\"lumiera\" -DPACKAGE_VERSION=\"0.1pre\" "-DPACKAGE_STRING=\"lumiera 0.1pre\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"lumiera\" -DVERSION=\"0.1pre\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -D__EXTENSIONS__=1 -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D_POSIX_PTHREAD_SEMANTICS=1 -D_TANDEM_SOURCE=1 -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -DHAVE_PTHREAD=1 -DEBUG_ALPHA=1 -DHAVE_EXECINFO_H=1 "-DHAVE_BOOST=/**/" -DHAVE_X11_XLIB_H=1 -DHAVE_X11_XUTIL_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1 -DHAVE_X11_EXTENSIONS_XVLIB_H=1 -DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_NOBUG_H=1 -DHAVE_NOBUGMT_H=1 -I. -I.. -I../src/ -pthread -I/usr/local/include -std=gnu99 -Wall -Wextra -Werror -g-O2 -pthread -MT liblumiera_la-time.lo -MD -MP -MF .deps/liblumiera_la-time.Tpo -c ../src/lib/time.c  -fPIC -DPIC -o .libs/liblumiera_la-time.o
Dans le fichier inclus à partir de ../src/lib/time.h:26,
          à partir de ../src/lib/time.c:23:
@@/usr/include/gavl/gavl.h:31:24: erreur: gavlconfig.h : Aucun fichier ou dossier de ce type

The problem here is that we use pkg-config to retrieve information about the gavl installation which tells on debian/ubuntu that the includedir=/usr/include and then we include <gavl/gavl.h>. Whereas the includedir should be /usr/include/gavl/ and we should just include <gavl.h>.

The problem now is that Mandriva installs the gavl headers directly in /usr/include (/usr/include/gavl.h etc..). So the include <gavl/gavl.h> fails.

What would be a proper fix for this problem? shall we explicitly check in configure.ac where gavl.h is located?

Change History

comment:1 Changed 3 years ago by ichthyo

...so basically the Mandriva installation seems to be broken, because there pkg-config tells
the wrong path. Or not? What is Burkhard's opinion, i.e. what does he intend/prefer?
<gavl/gavl.h> or just <gavl.h>

Of course we can fix broken packages in our buildscripts, but, especially because Gmerlin/Gavl
is relatively new to the packagers, maybe we might try to get "upstream" alinged on this issue?

comment:2 Changed 3 years ago by gmerlin

  • Status changed from new to closed
  • Resolution set to done

#include <gavl/gavl.h> is preferred, but that isn't related to the
bugreport.

The missing header gavlconfig.h was kicked out of gavl some time
ago. Upgrading gavl will solve this.

comment:3 Changed 3 years ago by ct

  • Status changed from closed to reopened
  • Resolution done deleted

Nice to have it fixed in gavl. But this ticket was about Lumiera and compiling it on mainstream distros. Maybe we shall bump the version requirement then so people have to install a newer gavl. Anyways, I reopen it until resolved.

comment:4 follow-up: ↓ 5 Changed 3 years ago by ichthyo

I think we should consider to bump up the version requirement anyway, at least to 1.0

comment:5 in reply to: ↑ 4 Changed 3 years ago by ct

  • Type changed from fixme to todo

Replying to ichthyo:

I think we should consider to bump up the version requirement anyway, at least to 1.0

Agreed, still, as long mandriva or other distros don't ship a 1.0+ gavl the problem would be just shifted (anyways, it is in lenny which we defined as base, so just let them somehoe install gavl 1.0+ on other distros). I change the ticket to 'todo' now so we can do this version bump soon and close it then, no need to rush.

comment:6 Changed 3 years ago by gmerlin

Do what you want, but note that gavl bugreports for old versions are pretty meaningless.

comment:7 Changed 9 months ago by ichthyo

  • Status changed from reopened to closed
  • Resolution set to worksforme

While we didn't do anything (besides verifying that we #include <gavl/gavl.h>, I consider that problem as solved just by waiting long enough :)

Regarding the GAVL version: we best stick just to what is in our Debian reference distibution, until we hit a real problem in functionality which requires us to use (and distribute) a newer version/backport via our own Apt repo.

Note: See TracTickets for help on using tickets.