Ticket #250 (closed fixme: done)

Opened 2 years ago

Last modified 3 weeks ago

Use new NoBug facilities for tests

Reported by: ct Owned by: skangas
Priority: normal Milestone: 2beta
Component: smallTasks Keywords: tests cleanup
Cc: Blocked By:
Blocking: #165

Description

The new NoBug includes 2 macros:

ECHO for logging
CHECK for assertions

Both are always active, no matter what build level was chosen.
They are exactly made for testsuites since it is not intended that tests are optimized out in BETA or RELEASE builds.

A lot of tests using other macros still (ASSERT, REQUIRE, TRACE,...)
This has to be fixed until we do a beta release (and possibly earlier) otherwise the testsuite will not work properly anymore.

This is a simple task someone for some novice, basically it is about substituting texts and it works direclty on the testsuite so the validity of the works can easily assured.

Change History

comment:1 Changed 2 years ago by ichthyo

  • Blocking 165 added

comment:2 Changed 2 years ago by ct

  • Keywords meeting added

comment:3 Changed 2 years ago by ct

  • Keywords meeting removed
  • Component changed from lumiera to smallTasks

This is a little job which involve mostly search&replace and check that the testsuite still passes, maybe fix it.

Any newbie can take this job, there is nothing to break and we will assist you to get used to this.

comment:4 Changed 14 months ago by ichthyo

  • Owner set to skangas
  • Status changed from new to assigned

Stefan did already a huge part of this work

Is there anything left? or can we close this ticekt?

comment:5 follow-up: ↓ 6 Changed 3 weeks ago by ichthyo

  • Status changed from assigned to closed
  • Resolution set to done

done since quite some time

comment:6 in reply to: ↑ 5 Changed 3 weeks ago by ct

Replying to ichthyo:

done since quite some time

doing

rgrep 'REQUIRE\|ENSURE\|ASSERT' tests/

shows still quite some hits, are these ok? I didn't checked that yet, ignore me if this is a false claim.

comment:7 Changed 3 weeks ago by ichthyo

Replying to ct:

rgrep 'REQUIRE\|ENSURE\|ASSERT' tests/

shows still quite some hits, are these ok?

Thanks for the hands-on

I've re-verified them just now: these are real assertions or pre/postconditions.
In the test src-trees are also some test helper facilities, e.g. a Test-"frame" filled with verifiable pseudo-random data;
these use the assertions, pre- and post conditions in the usual way, and distinct from the actual tests, which use
then CHECK for the test conditions to hold.

Note: See TracTickets for help on using tickets.